SMOODEV-2382: Mobile SDK consumption enablers (ADR-074)#120
Merged
Conversation
SPM can only resolve a manifest at the repo root, so the Swift SDK gets a root Package.swift aliasing swift/Sources (consumers pin a revision — the cargo-git-dep house pattern; CI now validates the root manifest). Android consumes via JitPack: jitpack.yml + maven-publish publication (com.github.SmooAI:config:<sha>), with Maven Central under ai.smoo as the durable follow-up. Sweeps ADR-073 → ADR-074 references (073 was concurrently claimed by the Karpenter bootstrap-island workstream). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MPVyaZaAGgvFRUq34z4qJ8
|
brentrager
added a commit
that referenced
this pull request
Jul 8, 2026
… typed errors (#123) * SMOODEV-2389: Untrack root .build/ — committed SPM module cache breaks other machines The root SPM manifest change (SMOODEV-2382, #120) committed 2302 files of .build/ module cache because .gitignore only covered swift/.build/. pcm files bake absolute module-cache paths, so any other checkout fails 'swift test' at the root manifest with 'precompiled file ... was compiled with module cache path ...' fatalError. Untrack and ignore. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LE7V35vzRiHyxBFE8wAxb4 * SMOODEV-2389: Mobile SDK parity — Swift sync publicValue, step clamp, typed errors, Closeable The parity audit against docs/Mobile-Runtime-Mode-Spec.md and the TS/Rust SDKs found four gaps: - Swift SmooConfig was an actor, so publicValue(forKey:) required await — violating spec row 2 (boot config resolves synchronously, offline). Now a lock-guarded final class, the structural twin of Kotlin's @Volatile/@synchronized. Async evaluate paths are unchanged for callers. - evaluateLimit in both SDKs clamped to [min,max] but skipped step snapping, so a step-defined limit resolved differently on mobile than TS clampLimit / Rust clamp_limit (ADR-066). step now snaps to the nearest multiple BEFORE the clamp, same order as the references. - Evaluate failures collapsed to a bare status int. Both SDKs now throw the typed hierarchy (flag/limit × notFound/context/evaluation) carrying the key, mirroring TS FeatureFlagEvaluationError et al. - Kotlin's Ktor HttpClient leaked; SmooConfig is now Closeable. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LE7V35vzRiHyxBFE8wAxb4 --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
WS4 prerequisites so the mobile apps can actually depend on the SDKs:
Package.swift— SPM only resolves at repo root; aliasesswift/Sources+Tests. Verified:swift testfrom root runs all 7 tests. CIswift_checksnow validates the root manifest (what consumers resolve).jitpack.yml+maven-publish— Android consumescom.github.SmooAI:config:<sha>via JitPack. Verified locally:gradle publishToMavenLocalproduces jar+pom+module. Maven Central underai.smoofiled as the durable follow-up.Epic: SMOODEV-2377.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MPVyaZaAGgvFRUq34z4qJ8